[augeas-devel] [Fwd: Re: [Openais] [PATCH corosync_trunk] Add augeas lense for corosync.conf]

[Steven Dake]

the augeas-devel ml requires subscription and bounced my original post
on this subject.


On Wed, 2010-02-17 at 22:21 +1100, Angus Salkeld wrote:
> On Wed, 2010-02-17 at 07:47 +0100, Fabio M. Di Nitto wrote:
> > I only have a few comments, some of them we discussed on IRC.
> > 
> > When adding new files, you need to update the corosync.spec.in too.
> > In general my policy has always been that (s)rpm from development
should
> > enable all features and ships all files.
> > 
> > Since those files are useful only when augtool are available, I
suggest
> > you create a separate binary rpm to ship them (call it
corosync-augeas
> > for example) that will Requires: augeas as dependency.
> > 
> > This way, it´s clear what those files do, they don´t interfere with
> > normal packaging, and they become optionally installable even in
testing.
> > 
> > Fabio
> > 
> 
> Here is a patch that should do the trick.
> 

According to augeas upstream, separate rpms are not recommended unless
there is a dependency on augtool or library.

The issue with this spec file patch is that it creates unowned dirs
(+%{_datadir}/augeas/lenses).  Some distros (fedora) own these dirs in
the "filesystem" package.  It is not clear to me that other distros will
do that, and instead choose to own them in the augeas packages (in which
case a dependency on augeas makes since, so that it can own the proper
dirs).

It is not possible to predict what adoptors of augeas will do with
regard to the lens dir owning issue.  There is even conflict in this
adoption for example - Fabio believes aug should own the dirs (assumed
from the above suggestion), fedora believes filesystem should own the
dirs.  Until that is sorted out upstream, I don't want to modify the
spec file with something that can create problems for corosync distro
adoption.  So while Fabio's policy is generally the right thing to do,
in this case NACK on the specfile suggestions until upstream and distros
come to consensus on this issue.

>From an adoptor's perspective, the augeas package should own the dir
and
there should be a corosync-augeas rpm created as suggested in this patch
that is dependent on augeas.  As can be seen by this ambiguity, this
little nitpicky issue can quickly create alot of conflict for adoptors
to ship lenses when the issue hasn't been sorted out clearly with
upstream and distros.

Regards
-steve

> -Angus
> 
> Index: corosync.spec.in
> ===================================================================
> --- corosync.spec.in  (revision 2658)
> +++ corosync.spec.in  (working copy)
> @@ -43,6 +43,7 @@
>  %{configure} \
>       --enable-nss \
>       --enable-rdma \
> +     --enable-augeas \
>       --with-initddir=%{_initddir}
>  
>  %build
> @@ -210,6 +211,22 @@
>  %{_mandir}/man8/coroipc_overview.8*
>  %{_mandir}/man8/sam_overview.8*
>  
> +%package -n corosync-augeas
> +BuildArch: noarch
> +Summary: The Augeas len for the Corosync Cluster Engine configuration
file
> +Group: System Environment/Libraries
> +Requires: %{name} = %{version}-%{release}
> +Requires: augeas
> +
> +%description -n corosync-augeas
> +This package contains the augeas lens for corosync.conf.
> +
> +%files -n corosync-augeas
> +%defattr(-,root,root,-)
> +%doc LICENSE
> +%{_datadir}/augeas/lenses/corosync.aug
> +%{_datadir}/augeas/lenses/tests/test_corosync.aug
> +
>  %changelog
>  * @date@ Autotools generated version <nobody at nowhere.org> -
@version at -1.@alphatag@
>  - Autotools generated version
> Index: Makefile.am
> ===================================================================
> --- Makefile.am       (revision 2658)
> +++ Makefile.am       (working copy)
> @@ -33,7 +33,8 @@
>  
>  TARFILE                      = $(PACKAGE_NAME)-$(VERSION).tar.gz
>  
> -EXTRA_DIST           = autogen.sh conf/corosync.conf.example
$(SPEC).in
> +EXTRA_DIST           = autogen.sh conf/corosync.conf.example
$(SPEC).in \
> +                       conf/lenses/corosync.aug
conf/lenses/tests/test_corosync.aug
>  
>  AUTOMAKE_OPTIONS     = foreign
>  
> 
> 
-------------- next part --------------
An embedded message was scrubbed...
From: Steven Dake <sdake at redhat.com>
Subject: Re: [Openais] [PATCH corosync_trunk] Add augeas lense for	corosync.conf
Date: Wed, 17 Feb 2010 13:35:58 -0700
Size: 4711
URL: <http://listman.redhat.com/archives/augeas-devel/attachments/20100217/b7fdcd6c/attachment.eml>