[augeas-devel] [PATCH] Fix crasher in ast.c:dict_pos on i686 with gcc 4.5 and -O2

[Matthew Booth]

On 11/18/2010 11:13 AM, Matthew Booth wrote:
> On 11/18/2010 10:19 AM, David Lutterkort wrote:
>> On Fri, 2010-11-12 at 11:24 +0000, Matthew Booth wrote:
>>> This patch works around what appears to be an optimization bug in gcc
>>> 4.5. The
>>> symptom of the bug is that dict_pos, called from dict_lookup,
>>> receives an
>>> invalid value when accessing dict->used. The following ticket
>>> describes the bug,
>>> and includes a simple test case:
>>>
>>> https://fedorahosted.org/augeas/ticket/149
>>
>> ACK. Nice sleuthing. I like this fix better than forcing the compiler to
>> not optimize in dict_pos since this fix makes it less likely that we get
>> an invalid dict->used anyway.
>>
>> Just pushed as commit c17cd53d
>
> Thanks, David. Do you mind if I push new builds to F13 and F14?

Scratch that, just F14. F13 doesn't hit this issue, of course.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490