[augeas-devel] [PATCH] avoid double-free upon fclose failure

[Jim Meyering]

Hello, here's a small patch for an unlikely double-free.
Spotted by coverity.

>From e316f0edaa71c490e4b4b663a927d1d6d2001bc4 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering at redhat.com>
Date: Wed, 16 Nov 2011 11:56:29 +0100
Subject: [PATCH] avoid double-free upon fclose failure

* src/transform.c (transform_save): Upon initial fclose failure,
set "fp = NULL;" so that we don't attempt to free/close "fp" while
cleaning up upon "goto done".
---
 src/transform.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/transform.c b/src/transform.c
index b96650a..71f3f93 100644
--- a/src/transform.c
+++ b/src/transform.c
@@ -991,6 +991,7 @@ int transform_save(struct augeas *aug, struct tree *xfm,

     if (fclose(fp) != 0) {
         err_status = "close_augnew";
+        fp = NULL;
         goto done;
     }

--
1.7.8.rc2