[augeas-devel] [PATCH] Fix enable span not working

[Francis Giraldeau]

Hi, 

> You beat me to it Francis, I'm just finishing my own patch to fix it.
> However, I do not agree with the patch, see below.

That's funny ;)

>         
>         -    if (! streqv(AUG_DISABLE, option)) {
>         +    if (!(cmd->aug->flags & AUG_ENABLE_SPAN)) {
> 
> 
> This will only work if AUG_ENABLE_SPAN was passed as a flag. However,
> users can set /augeas/span manually, and it won't work here. Instead,
> we should use the way it was done in 0.8.0:

Yeah, but if the user set it to enable and don't reload, then "No span
info" error will be displayed. Would it be better then to highlight the
reload procedure? The test with the flags ensure that at the previous
load the span option was effective.

> 
> This check is still useful, it just has to be reversed.
> I'll send my patch along in a minute.

Yeah, you're probably right, it's not the time to change this behavior
in a bug fix.

I'll let you finish ;)

Thanks!

Francis