[augeas-devel] [PATCH] add missing SUSE and RHN files to lenses/shellvars.aug

[Dominic Cleal]

On 27/02/12 15:45, Duncan Mac-Vicar P. wrote:
> On 02/27/2012 03:35 PM, Dominic Cleal wrote:
>> Thanks Duncan.  I'm tempted to change Shellvars to simply include
>> /etc/sysconfig/* and /etc/default/*, then deal with exceptions when
>> parsing fails, rather than take on this never ending battle.
>>
>> Does anybody else object?
>>
> 
> You can do that and additionally handle a blacklist.
> 
> (ie: /etc/sysconfig/SuSEfirewall2.d/services/TEMPLATE )

I've made this change now in git, excluding the above file plus a few
more I found on my Fedora 16 system.  The good news is that it caused
another 26 files to be parsed here.

The new lens is here:
http://git.fedorahosted.org/git/?p=augeas.git;a=blob;f=lenses/shellvars.aug

Could you please try it out (augtool -I <lens dir>) and let me know if
there are any more exclusions required for non-shellvars files caught
with the glob or if valid files fail to parse?

Run "print /augeas//error" in augtool to capture a list of files and errors.

Thanks,

-- 
Dominic Cleal
Red Hat Consulting
m: +44 (0)7817 878113