[augeas-devel] dhcpd change for quoted characters

[Raphaël Pinson]

Hello Robert,

This would indeed be an incompatible change, but a kind we've introduced
for other lenses in the past, so it's acceptable imo.

As for how to fix this technically, the Quote module should now be used for
this.

Regards,

--
Raphaël Pinson
Infrastructure Developer & Trainer
+33 479 26 57 93
+33 781 90 00 79

Camptocamp France
Savoie Technolac
BP 352
48, avenue du Lac du Bourget
73372 Le Bourget-du-Lac, Cedex
Le 23 févr. 2014 07:55, "Robert Drake" <rdrake at direcpath.com> a écrit :

> I think it's best to start off showing what I'm doing with an example test
> that fails:
>
> test Dhcpd.lns get "class \"ugly quotes\" {}" =
>   { "class" = "ugly quotes" }
>
> Test failure:/home/rdrake/code/augeas/lenses/tests/test_
> dhcpd.aug:518.0-519.29:
>  Expected:
> {
>   { "class" = "ugly quotes" }
> }
>
>  Actual:
> {
>   { "class" = ""ugly quotes"" }
> }
>
> The reason it's doing this is because rather than processing the quotes
> the code just stores anything leading up to a space:
>
> let stmt_block_arg (body:lens)
>                       = [ indent . key stmt_block_arg_re . sep_spc .
> sto_to_spc . sep_obr . body* . sep_cbr ]
>
> sto_to_spc actually matches on quoted values, but doesn't delete the
> quotes:
>
> let sto_to_spc        = store /[^\\#,;\{\}" \t\n]+|"[^\\#"\n]+"/
>
>
> Now, this isn't bad to fix but so far I've been trying to leave the output
> alone so everyone's existing scripts would work.  Changing this to match
> quotes would mean that anyone counting on the current way would be broken
> next time they upgraded.  Is that okay or should I just leave it alone?  I
> could always make a new dhcpd4.aug that people could use if they needed the
> new stuff.
>
> _______________________________________________
> augeas-devel mailing list
> augeas-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/augeas-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/augeas-devel/attachments/20140223/2049e64c/attachment.htm>