[Avocado-devel] Broken cartesian_config by commit 81c6ce860b2f625e

Andrei Stepanov astepano at redhat.com
Fri Aug 19 08:22:06 UTC 2016


Attached configs.

On Fri, Aug 19, 2016 at 4:02 AM, Wei, Jiangang <weijg.fnst at cn.fujitsu.com>
wrote:

> Hi
> On Thu, 2016-08-18 at 12:06 +0200, Andrei Stepanov wrote:
> > spice configs
> > http://file.brq.redhat.com/astepano/tmp/spice-configs.tar.gz
>
> I can't fetch the config file.
> Is it big? If not, may i ask you to attach it to email?
>
> Thanks,
> wei
> >
> >
> > to test use:
> >
> >
> > $ cartesian_config.py tests.cfg
> >
> >
> >
> >
> > On Thu, Aug 18, 2016 at 11:50 AM, Andrei Stepanov
> > <astepano at redhat.com> wrote:
> >         Hello.
> >
> >
> >         We have now broken cartesian_config.py.
> >
> >
> >         It was broken by:
> >
> >
> >         commit 81c6ce860b2f625ec31533779c479cf9bf14af38
> >         Author: Xu Tian <xutian at redhat.com>
> >         Date:   Mon May 23 15:10:48 2016 +0800
> >
> >
> >             virttest.cartesian_config: enable postfix_parse
> >
> >             postfix string '_fixed', '_max' and '_min' doesn't work,
> >         because
> >             'postfix_parse' not call in get_dict function. this commit
> >         enable
> >             it, because tp-qemu tests need these params.
> >
> >             Signed-off-by: Xu Tian <xutian at redhat.com>
> >
> >
> >
> >
> >
> >
> >         The error is:
> >
> >
> >         [root at localhost cfg]# cartesian_config.py tests.cfg
> >         Traceback (most recent call last):
> >           File
> >         "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_config.py",
> line 2301, in <module>
> >             print_dicts(options, dicts)
> >           File
> >         "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_config.py",
> line 2187, in print_dicts
> >             print_dicts_default(options, dicts)
> >           File
> >         "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_config.py",
> line 2160, in print_dicts_def
> >         ault
> >             for count, dic in enumerate(dicts):
> >           File
> >         "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_config.py",
> line 1939, in get_dicts
> >             for d in self.get_dicts_plain(node, ctx, content,
> >         shortname, dep):
> >           File
> >         "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_config.py",
> line 2145, in get_dicts_plain
> >             for d in self.get_dicts(n, ctx, new_content, shortname,
> >         dep):
> >           File
> >         "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_config.py",
> line 1939, in get_dicts
> >             for d in self.get_dicts_plain(node, ctx, content,
> >         shortname, dep):
> >
> >
> >         .....
> >
> >
> >           File
> >         "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_config.py",
> line 2145, in get_dicts_plain
> >             for d in self.get_dicts(n, ctx, new_content, shortname,
> >         dep):
> >           File
> >         "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_config.py",
> line 1942, in get_dicts
> >             postfix_parse(d)
> >           File
> >         "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_config.py",
> line 2244, in postfix_parse
> >             if key.endswith("_max"):
> >         AttributeError: 'tuple' object has no attribute 'endswith'
> >
> >
> >
> >
> >         If I do:
> >
> >
> >         git revert 81c6ce860b2f625ec31533779c479cf9bf14af38
> >
> >
> >
> >         than I do not have such error. Please fix.
> >
> >
> >
> >
> >
> >
> >
> >
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/avocado-devel/attachments/20160819/af6ad7e9/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: spice-configs.tar.gz
Type: application/x-gzip
Size: 81159 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/avocado-devel/attachments/20160819/af6ad7e9/attachment.bin>


More information about the Avocado-devel mailing list