[Avocado-devel] Issues: pf assignable testing

[Xu Han]

On Tue, Aug 23, 2022 at 9:32 AM <wuzhiguo at loongson.cn> wrote:

> Hi Xu Han,
>
>
> Thanks very much for your help.
>
> And I found that testcases can pass just with "set the `mac` param to the
> PF nic device with its actual value".
>

My pleasure, thanks!

Best regards,
Xu Han


>
> Best Regards,
>
> Zhiguo Wu
>
> -----Original Messages-----
> *From:*"Xu Han" <xuhan at redhat.com>
> *Sent Time:*2022-08-19 17:38:00 (Friday)
> *To:* wuzhiguo at loongson.cn
> *Cc:* "avocado-devel at redhat.com" <avocado-devel at redhat.com>, "Lukas
> Doktor" <ldoktor at redhat.com>, "Kyla Zhang" <weizhan at redhat.com>
> *Subject:* Re: [Avocado-devel] Issues: pf assignable testing
>
> Hello Zhiguo Wu,
>
> Firstly, thank you for your attention to the avocado project!
>
> It seems that the PF/VF assignment functionality has not been maintained
> for a few years, and hence I don't even sure about if these kinds of tests
> could be run properly. But I will try to answer your questions as much as I
> can.
>
> On Mon, Aug 15, 2022 at 8:46 PM <wuzhiguo at loongson.cn> wrote:
> >
> > Dear avocado development team,
> >
> >
> > In pf assignable testing, I found some issue:
> >
> > 1. guest-hw.cfg:  driver not set in pf_assignable variants.
>
> Would you please elaborate more about the issue you encountered so that it
> can help me understand that? thanks!
>
> >
> > 2. Avocado always try to find IP for mac which is generated by
> virtnet.generate_mac_address(), not for pf assignable device's mac. So test
> failed.
> >
> >     For example, mac of pf assignable device is "90:e2:ba:34:bf:e6", but
> avocado always try to find IP for mac (9a:7a:7f:25:5c:c3)
>
> This looks like a bug. Anyway, could you please try with the following to
> see if it can workaround the issue?
>
> 1. apply the patch below to avocado-vt.
>
> diff --git a/virttest/qemu_vm.py b/virttest/qemu_vm.py
> index 6706b097..dfd6d5bc 100644
> --- a/virttest/qemu_vm.py
> +++ b/virttest/qemu_vm.py
> @@ -3011,6 +3011,8 @@ class VM(virt_vm.BaseVM):
>                      elif pa_type == "pf":
>
>  self.pci_assignable.add_device(device_type=pa_type,
>                                                         name=name)
> +                        self.virtnet.set_mac_address(nic["nic_name"],
> +                                                     nic_params["mac"])
>                      else:
>                          raise virt_vm.VMBadPATypeError(pa_type)
>                  else:
>
> 2. set the `mac` param to the PF nic device with its actual value, for
> example,
>
> mac_nicpf1 = 90:e2:ba:34:bf:e6
>
> ('nicpf1' is the logic name of the PF nic in this example, please replace
> it with the one used in your case.)
>
> Best regards,
> Xu Han
>
> >
> > Could you please share your comments ?
> >
> >
> > Best Regards,
> >
> > Zhiguo Wu
>
>
>
>
> *本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。 This
> email and its attachments contain confidential information from Loongson
> Technology , which is intended only for the person or entity whose address
> is listed above. Any use of the information contained herein in any way
> (including, but not limited to, total or partial disclosure, reproduction
> or dissemination) by persons other than the intended recipient(s) is
> prohibited. If you receive this email in error, please notify the sender by
> phone or email immediately and delete it. *
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/avocado-devel/attachments/20220823/dfa957b6/attachment-0001.htm>