[Cluster-devel] [2.6 patch] fs/gfs2/dir.c:gfs2_dir_write_data(): remove dead code

Adrian Bunk bunk at stusta.de
Thu Oct 19 13:12:24 UTC 2006


The Coverity checker spotted this obviously dead code.

Signed-off-by: Adrian Bunk <bunk at stusta.de>

--- linux-2.6/fs/gfs2/dir.c.old	2006-10-19 01:07:42.000000000 +0200
+++ linux-2.6/fs/gfs2/dir.c	2006-10-19 01:07:49.000000000 +0200
@@ -209,14 +209,12 @@ static int gfs2_dir_write_data(struct gf
 		if (error)
 			goto fail;
 
 		gfs2_trans_add_bh(ip->i_gl, bh, 1);
 		memcpy(bh->b_data + o, buf, amount);
 		brelse(bh);
-		if (error)
-			goto fail;
 
 		buf += amount;
 		copied += amount;
 		lblock++;
 		dblock++;
 		extlen--;




More information about the Cluster-devel mailing list