[Cluster-devel] [DLM][PATCH] lowcomms init fixes

Josef Bacik jwhiter at redhat.com
Mon Apr 23 15:15:45 UTC 2007


On Mon, Apr 23, 2007 at 11:19:52AM +0100, Patrick Caulfield wrote:
> Thanks for finding & fixing those bugs Josef.
> I've changed the patch a little, making the comparison always <= max_nodeid, I
> prefer max_modeid to be what it says it as and not 1 more than the max node ID.
> 
> I'm a little concerned about the need for idr_init() in lowcomms_close(). Surely
> if the idr was properly cleaned out it would not be necessary - though somehow
> it seems to be, Do you know what's actually happening here ?
> 
> Anyway, here's the modified patch. it seems to work for me, but I'd be grateful
> if you could run it through your tests too, cos I'm supposed to be working on
> something else at the moment!
> 
> Steve, can you wait till Josef has tested this patch before adding it to the git
> tree? thanks.
> 

K I tested it and it works great, thanks much Patrick.

Josef




More information about the Cluster-devel mailing list