[Cluster-devel] [GFS2 patch] fix locking mistake

[Andrew Morton]

On Tue, 20 Feb 2007 00:03:29 -0500
Josef Whiter <jwhiter at redhat.com> wrote:

> This patch fixes a locking mistake in the quota code, we do a mutex_lock instead
> of a mutex_unlock.
> 
> Signed-off-by: Josef Whiter <jwhiter at redhat.com>
> 
> --- linux-2.6/fs/gfs2/quota.c.josef	2007-02-20 00:41:23.000000000 -0500
> +++ linux-2.6/fs/gfs2/quota.c	2007-02-20 00:51:58.000000000 -0500
> @@ -279,7 +279,7 @@ static int bh_get(struct gfs2_quota_data
>  		(bh->b_data + sizeof(struct gfs2_meta_header) +
>  		 offset * sizeof(struct gfs2_quota_change));
>  
> -	mutex_lock(&sdp->sd_quota_mutex);
> +	mutex_unlock(&sdp->sd_quota_mutex);
>  
>  	return 0;
>  

whaaa?  There's no way that any of that code has ever been executed, surely??

Oh well, I'll tag this for consideration by the -stable team.