[Cluster-devel] [PATCH 1/4] libgfs2: Fix 'dubious one-bit signed bitfield' sparse errors

Bob Peterson rpeterso at redhat.com
Wed Aug 19 12:34:24 UTC 2009


----- "Andrew Price" <andy at andrewprice.me.uk> wrote:
| Fix these sparse errors:
| 
| libgfs2.h:575:11: error: dubious one-bit signed bitfield
| libgfs2.h:576:10: error: dubious one-bit signed bitfield
| libgfs2.h:577:13: error: dubious one-bit signed bitfield
| 
| Signed-off-by: Andrew Price <andy at andrewprice.me.uk>
| ---
|  gfs2/libgfs2/libgfs2.h |    6 +++---
|  1 files changed, 3 insertions(+), 3 deletions(-)
| 
| diff --git a/gfs2/libgfs2/libgfs2.h b/gfs2/libgfs2/libgfs2.h
| index 558283d..b3c9483 100644
| --- a/gfs2/libgfs2/libgfs2.h
| +++ b/gfs2/libgfs2/libgfs2.h
| @@ -572,9 +572,9 @@ extern struct gfs2_inode *gfs_inode_get(struct
| gfs2_sbd *sdp,
|  /* gfs2_log.c */
|  struct gfs2_options {
|  	char *device;
| -	int yes:1;
| -	int no:1;
| -	int query:1;
| +	unsigned int yes:1;
| +	unsigned int no:1;
| +	unsigned int query:1;
|  };
|  
|  #define MSG_DEBUG       7
| -- 
| 1.6.3.3
Hi,

ACKed by Bob Peterson <rpeterso at redhat.com>

Regards,

Bob Peterson
Red Hat File Systems




More information about the Cluster-devel mailing list