[Cluster-devel] [PATCH 3/3] mkfs i18n:
Bob Peterson
rpeterso at redhat.com
Tue Sep 6 18:29:24 UTC 2011
Hi Carlos,
----- Original Message -----
| + do{
| + printf( _("\nAre you sure you want to proceed? [y/n]"));
| + ret = getline(&line, &len, stdin);
| + res = rpmatch(line);
I'd like to see the free(line); moved right here after rpmatch.
Otherwise multiple iterations through the loop will leak memory.
| +
| + if (res > 0){
With my suggestion above, this can be removed:
| + free(line);
Other than that, it looks good.
Regards,
Bob Peterson
Red Hat File Systems
More information about the Cluster-devel
mailing list