[Cluster-devel] [PATCH] gfs2: Make statistics unsigned, suitable for use with do_div()
Andreas Gruenbacher
agruenba at redhat.com
Wed Aug 26 14:08:55 UTC 2015
Ben,
[sorry about the previous botched reply, I didn't reveive your
original message via cluster-devel for some reason and bouncing it
through attachment / mutt into gmail somehow messed up your address.]
2015-08-26 2:21 GMT+02:00 Ben Hutchings <andreas.gruenbacher at gmail.com>:
> None of these statistics can meaningfully be negative, and the
> numerator for do_div() must have the type u64. The generic
> implementation of do_div() used on some 32-bit architectures asserts
> that, resulting in a compiler error in gfs2_rgrp_congested().
ACK. The only problem I see is when the clock runs backwards and we
end up with a garbage round-trip time; this could theoretically lead
to a negative average. (The variance cannot possible go negative
though.)
While reviewing this, I found an unrelated likely bug; posting separately.
Thanks,
Andreas
More information about the Cluster-devel
mailing list