[Cluster-devel] DLM portion of commit 16e5c1fc needs reverting or fixing "convert a bunch of open-coded instances of memdup_user_nul()"
Bob Peterson
rpeterso at redhat.com
Thu Jan 21 22:13:01 UTC 2016
Hi,
Al, this change to fs/dlm/user.c is wrong and needs fixing:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/fs/dlm/user.c?id=16e5c1fc36040e592128a164499bc25eb138a80f
There are two things:
- It uses !IS_ERR() where it should use IS_ERR()
- It doesn't set GFP_NOFS
Can you fix it please? Or do you want me to post a patch?
You might want to check the other changes in the set for similar things.
Regards,
Bob Peterson
Red Hat File Systems
More information about the Cluster-devel
mailing list