[Cluster-devel] [gfs2-utils PATCH 3/7] fsck.gfs2: Don't set gfs1rg pointer unless we need to

Bob Peterson rpeterso at redhat.com
Wed Jun 22 19:26:48 UTC 2016


This patch simply delays setting the gfs1rg pointer until later
in function check_n_fix_bitmap, making it a bit faster.

Signed-off-by: Bob Peterson <rpeterso at redhat.com>
---
 gfs2/fsck/metawalk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c
index cda59ac..651bd79 100644
--- a/gfs2/fsck/metawalk.c
+++ b/gfs2/fsck/metawalk.c
@@ -49,8 +49,6 @@ int check_n_fix_bitmap(struct gfs2_sbd *sdp, struct rgrp_tree *rgd,
 		prevrgd = rgd;
 	}
 
-	gfs1rg = (struct gfs_rgrp *)&rgd->rg;
-
 	old_state = lgfs2_get_bitmap(sdp, blk, rgd);
 	if (old_state < 0) {
 		log_err( _("Block %llu (0x%llx) is not represented in the "
@@ -93,6 +91,8 @@ int check_n_fix_bitmap(struct gfs2_sbd *sdp, struct rgrp_tree *rgd,
 		rgd->rg.rg_free--;
 		rewrite_rgrp = 1;
 	}
+	gfs1rg = (struct gfs_rgrp *)&rgd->rg;
+
 	/* If we're freeing a dinode, get rid of the data structs for it. */
 	if (old_state == GFS2_BLKST_DINODE ||
 	    old_state == GFS2_BLKST_UNLINKED) {
-- 
2.5.5




More information about the Cluster-devel mailing list