[Cluster-devel] [PATCH] gfs2: Remove a missed rcu_read_unlock() in gfs2_glock_get()

[Andreas Gruenbacher]

On Fri, Aug 4, 2017 at 12:39 PM, Andrew Price <anprice at redhat.com> wrote:
> Commit 64b8e0b83eaa "gfs2: gfs2_glock_get: Wait on freeing glocks"
> missed removing the final rcu_read_unlock() call.
>
> Signed-off-by: Andrew Price <anprice at redhat.com>
> ---
>  fs/gfs2/glock.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
> index fcbe478480f7..5ad757f0ce60 100644
> --- a/fs/gfs2/glock.c
> +++ b/fs/gfs2/glock.c
> @@ -881,7 +881,6 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number,
>         atomic_dec(&sdp->sd_glock_disposal);
>
>  out:
> -       rcu_read_unlock();
>         return ret;
>  }

It seems this fails on preemptible kernels only, so we didn't see it
in our previous testing.

Reviewed-by: Andreas Gruenbacher <agruenba at redhat.com>

Thanks,
Andreas