[Cluster-devel] [GFS2 PATCH] GFS2: Fix gfs2_log_write and eliminate gfs2_log_bmap

[Steven Whitehouse]

On 04/12/17 14:36, Bob Peterson wrote:
> | As explained in my previous email: "Death by a thousand cuts."
> | I much prefer the readability of one 17-line function to two
> | functions of 9 lines each.
>
> Make that one 9 line function and one 11 line function, since
> I'd need to add a check for the return code to get the same result.
>
> Bob Peterson

The function length is really irrelevant... the question is whether it 
does one logical thing. In this case mapping the block that we are about 
to write is one thing, and actually writing it, is another,

Steve.