[Cluster-devel] [PATCH 2/3] rhashtable: Add rhashtable_walk_curr

[Andreas Gruenbacher]

On 19 December 2017 at 00:38, Herbert Xu <herbert at gondor.apana.org.au> wrote:
> On Mon, Dec 18, 2017 at 02:31:21PM +0100, Andreas Gruenbacher wrote:
>> When iterating through an rhashtable is stopped with
>> rhashtable_walk_stop and then resumed with rhashtable_walk_start, there
>> currently is no way to get back to the current object and thus revisit
>> the object rhashtable_walk_next has previously returned.
>>
>> This functionality is useful when dumping an rhashtable via the seq file
>> interface: seq_read will convert one object after the other.  When an
>> object doesn't fit in the remaining buffer space anymore, user-space
>> will be returned all objects that have been fully converted so far.
>> Upon the next read from user-space, the object that didn't fit
>> previously will be revisited.
>>
>> Signed-off-by: Andreas Gruenbacher <agruenba at redhat.com>
>
> Doesn't the helper that Tom Herbert just added do exactly this?

Ah, I've missed that; rhastable_walk_peek apparently does what we need here.

By the way, git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master doesn't merge cleanly with current mainline.

Thanks,
Andreas