[Cluster-devel] [PATCH] gfs2: Add missing rcu locking for glock lookup

[Steven Whitehouse]

Hi,


On 22/02/17 15:26, Andreas Gruenbacher wrote:
> On Wed, Feb 22, 2017 at 4:13 PM, Steven Whitehouse <swhiteho at redhat.com> wrote:
>> Hi,
>>
>> Looks good, but can we fix that "retry for 100 times" loop too at the same
>> time? There does appear to be an rhashtable API function that does what we
>> need there,
> The rhashtable cleanup which I've posted separately doesn't actually
> affect the weird retry loop. The right thing to do here, so far, would
> be to retry forever I believe.
>
> Andreas
There should be no need to retry at all. Either the new entry will be 
added to the hash table, or it will find an existing entry in the table. 
Is there really some way this can fail for some reason? We ought not to 
need a loop here,

Steve.