[Cluster-devel] [PATCH] fs: gfs2: Adding new return type vm_fault_t

[Bob Peterson]

----- Original Message -----
> Use new return type vm_fault_t for page_mkwrite
> handler.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux at gmail.com>
> Reviewed-by: Matthew Wilcox <mawilcox at microsoft.com>
> ---
>  fs/gfs2/file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
> index 4f88e20..2c471d6 100644
> --- a/fs/gfs2/file.c
> +++ b/fs/gfs2/file.c
> @@ -387,7 +387,7 @@ static int gfs2_allocate_page_backing(struct page *page)
>   * blocks allocated on disk to back that page.
>   */
>  
> -static int gfs2_page_mkwrite(struct vm_fault *vmf)
> +static vm_fault_t gfs2_page_mkwrite(struct vm_fault *vmf)
>  {
>  	struct page *page = vmf->page;
>  	struct inode *inode = file_inode(vmf->vma->vm_file);
> --
> 1.9.1

Hi,

This patch is straightforward enough, but there are a lot of other
file systems that need similar patches. Shouldn't you do one big
patch set that fixes several file systems at once and run it through
Viro's kernel or Linus's kernel or something?
Adding Viro and linux-fsdevel for more opinions.

Regards,

Bob Peterson