[Cluster-devel] [PATCH] gfs2: Dirty source inode during rename

Bob Peterson rpeterso at redhat.com
Wed Feb 28 21:16:18 UTC 2018


----- Original Message -----
| Mark the source inode dirty during a rename instead of just updating the
| underlying buffer head.  Otherwise, fsync may find the inode clean and
| will then skip flushing the journal.  A subsequent power failure will
| cause the rename to be lost.  This happens in command sequences like:
| 
|   xfs_io -f -c 'pwrite 0 4096' -c 'fsync' foo
|   mv foo bar
|   xfs_io -c 'fsync' bar
|   # power failure
| 
| Signed-off-by: Andreas Gruenbacher <agruenba at redhat.com>
| ---
|  fs/gfs2/dir.c   | 13 ++-----------
|  fs/gfs2/inode.c | 10 +---------
|  2 files changed, 3 insertions(+), 20 deletions(-)

Hi,

Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree:

https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=e49f900d6e610ba6c9e6138f132eb37e91bddb37

Regards,

Bob Peterson
Red Hat File Systems




More information about the Cluster-devel mailing list