[Cluster-devel] [PATCH] fs: gfs2: Fix a null-pointer dereference in gfs2_alloc_inode()

[Christoph Hellwig]

On Wed, Jul 24, 2019 at 11:22:46AM +0100, Steven Whitehouse wrote:
> and it would have the same effect, so far as I can tell. I don't mind
> changing it, if that is perhaps a clearer way to write the same thing,
> rather than &ip->i_inode;

The cleanest thing is to not rely on any of that magic and write it
like all other file systems:

	ip = kmem_cache_alloc
	if (!ip)
		retuturn NULL;

	...

	return &ip->i_inode;

Absolutely not point in trying to be clever here.