[Cluster-devel] [gfs2:for-next.bob6b 5/12] fs/gfs2/meta_io.c:400:21: warning: no previous prototype for 'gfs2_getjdatabuf'

kernel test robot lkp at intel.com
Thu Jul 30 21:38:44 UTC 2020


tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git for-next.bob6b
head:   e113c11c3dacf984d0e6c6a53e78940727c2f52f
commit: 814995ea785119dac948329e509217d15ac6beb0 [5/12] gfs2: Wipe jdata and ail1 in gfs2_journal_wipe, formerly gfs2_meta_wipe
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 814995ea785119dac948329e509217d15ac6beb0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>

All warnings (new ones prefixed by >>):

   In file included from arch/xtensa/include/asm/processor.h:15,
                    from arch/xtensa/include/asm/thread_info.h:20,
                    from arch/xtensa/include/asm/current.h:14,
                    from include/linux/sched.h:12,
                    from fs/gfs2/meta_io.c:7:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/xtensa/include/asm/page.h:193:9: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
     193 |  ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr)
         |         ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   arch/xtensa/include/asm/page.h:201:32: note: in expansion of macro 'pfn_valid'
     201 | #define virt_addr_valid(kaddr) pfn_valid(__pa(kaddr) >> PAGE_SHIFT)
         |                                ^~~~~~~~~
   include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   fs/gfs2/meta_io.c: At top level:
>> fs/gfs2/meta_io.c:400:21: warning: no previous prototype for 'gfs2_getjdatabuf' [-Wmissing-prototypes]
     400 | struct buffer_head *gfs2_getjdatabuf(struct gfs2_inode *ip, u64 blkno)
         |                     ^~~~~~~~~~~~~~~~

vim +/gfs2_getjdatabuf +400 fs/gfs2/meta_io.c

   399	
 > 400	struct buffer_head *gfs2_getjdatabuf(struct gfs2_inode *ip, u64 blkno)
   401	{
   402		struct address_space *mapping = ip->i_inode.i_mapping;
   403		struct gfs2_sbd *sdp = GFS2_SB(&ip->i_inode);
   404		struct page *page;
   405		struct buffer_head *bh;
   406		unsigned int shift = PAGE_SHIFT - sdp->sd_sb.sb_bsize_shift;
   407		unsigned long index = blkno >> shift; /* convert block to page */
   408		unsigned int bufnum = blkno - (index << shift);
   409	
   410		page = find_get_page_flags(mapping, index, FGP_LOCK|FGP_ACCESSED);
   411		if (!page)
   412			return NULL;
   413		if (!page_has_buffers(page)) {
   414			unlock_page(page);
   415			put_page(page);
   416			return NULL;
   417		}
   418		/* Locate header for our buffer within our page */
   419		for (bh = page_buffers(page); bufnum--; bh = bh->b_this_page)
   420			/* Do nothing */;
   421		get_bh(bh);
   422		unlock_page(page);
   423		put_page(page);
   424		return bh;
   425	}
   426	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 64419 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20200731/35cfb154/attachment.gz>


More information about the Cluster-devel mailing list