[Cluster-devel] [PATCH v2.1 11/30] iomap: add the new iomap_iter model

Dave Chinner david at fromorbit.com
Tue Aug 17 02:34:45 UTC 2021

On Wed, Aug 11, 2021 at 12:17:20PM -0700, Darrick J. Wong wrote:
> From: Christoph Hellwig <hch at lst.de>
> The iomap_iter struct provides a convenient way to package up and
> maintain all the arguments to the various mapping and operation
> functions.  It is operated on using the iomap_iter() function that
> is called in loop until the whole range has been processed.  Compared
> to the existing iomap_apply() function this avoid an indirect call
> for each iteration.
> For now iomap_iter() calls back into the existing ->iomap_begin and
> ->iomap_end methods, but in the future this could be further optimized
> to avoid indirect calls entirely.
> Based on an earlier patch from Matthew Wilcox <willy at infradead.org>.
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> [djwong: add to apply.c to preserve git history of iomap loop control]
> Reviewed-by: Darrick J. Wong <djwong at kernel.org>
> Signed-off-by: Darrick J. Wong <djwong at kernel.org>

Looks like a straight translation of Christoph's original. Seems
fine to me as a simepl step towards preserving the git history.

Reviewed-by: Dave Chinner <dchinner at redhat.com>
Dave Chinner
david at fromorbit.com

More information about the Cluster-devel mailing list