[Cluster-devel] [PATCH v2 1/2] iomap: Don't create iomap_page objects for inline files

Christoph Hellwig hch at infradead.org
Tue Jul 6 05:03:50 UTC 2021


On Mon, Jul 05, 2021 at 08:18:23PM +0200, Andreas Gruenbacher wrote:
> In iomap_readpage_actor, don't create iop objects for inline inodes.
> Otherwise, iomap_read_inline_data will set PageUptodate without setting
> iop->uptodate, and iomap_page_release will eventually complain.
> 
> To prevent this kind of bug from occurring in the future, make sure the
> page doesn't have private data attached in iomap_read_inline_data.
> 
> Signed-off-by: Andreas Gruenbacher <agruenba at redhat.com>
> Reviewed-by: Matthew Wilcox (Oracle) <willy at infradead.org>

As mentioned last round I'd prefer to simply not create the iomap_page
at all in the readpage/readpages path.

Also this patch needs to go after the current patch 2 to be bisection
clean.




More information about the Cluster-devel mailing list