[Cluster-devel] [PATCH] gfs2: Delay withdraw from atomic context

Bob Peterson rpeterso at redhat.com
Fri Jul 30 18:33:02 UTC 2021

Before this patch, if function __gfs2_ail_flush detected an error
syncing the ail list, it call gfs2_ail_error which called gfs2_withdraw.
Since __gfs2_ail_flush deals with a specific glock, we shouldn't withdraw
immediately because the withdraw code (signal_our_withdraw) uses glocks
in its processing.

This patch changes the call from gfs2_withdraw to gfs2_withdraw_delayed
which defers the withdraw until a more appropriate context, such as the
logd daemon, discovers the intent to withdraw.

Reported-by: Dan Carpenter <dan.carpenter at oracle.com>

Signed-off-by: Bob Peterson <rpeterso at redhat.com>
 fs/gfs2/glops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c
index 744cacd27213..2eb03bbb2329 100644
--- a/fs/gfs2/glops.c
+++ b/fs/gfs2/glops.c
@@ -44,7 +44,7 @@ static void gfs2_ail_error(struct gfs2_glock *gl, const struct buffer_head *bh)
 	       gl->gl_name.ln_type, gl->gl_name.ln_number,
 	gfs2_lm(sdp, "AIL error\n");
-	gfs2_withdraw(sdp);
+	gfs2_withdraw_delayed(sdp);

More information about the Cluster-devel mailing list