[Crash-utility] crash ppc64 fixes to deal withper_cpu_offsetchanges

[Dave Anderson]

Badari Pulavarty wrote:

> On Mon, 2006-02-13 at 16:59 -0500, Dave Anderson wrote:
> > Badari Pulavarty wrote:
> >
> > > Hi,
> > >
> > > After 2.6.15, ppc64 per_cpu_offsets are moved to "paca"
> > > structure. Here is the patch to make crash read per-cpu-offsets
> > > from paca structure.
> > >
> > > Without this patch, you get following error while running
> > > crash. Please apply.
> > >
> > > crash: cannot determine idle task addresses from init_tasks[] or
> > > runqueues[]
> > >
> > > crash: cannot resolve "init_task_union"
> > >
> > > Thanks,
> > > Badari
> > >
> >
> > Hi Badari,
> >
> > This looks just fine to me.  Can you verify that "make Warn" compiles it
> > cleanly?  It looks like it should, but I don't have a ppc64 readily available.
> >
> > Also, a minor nit -- for debug purposes only -- can you add this new
> > "ppc64_paca" size display to the dump_offset_table() routine -- just
> > under the "x8664_pda" size display?
> >
>
> Okay. Here is the new version. I haven't introduced any warnings in this
> round, but I did in my previous round. I cleaned those now.
>
> I also added paca size display to dump_offset_table().

Ok, good -- thanks!

>
>
> BTW: crash is broken for CONFIG_SPARSEMEM (which seems to be default
> for ppc64). I had to hack it every time to make crash work on ppc64.
> Do you want to include temporary hack to make crash work till it
> gets fixed for real. (with the hack most commands work, but some memory
> related commands show wrong data).
>

Right, this issue came up during the last kexec/kdump conference call.
Anyway, I'd prefer to wait until for your real fix, which should hopefully
be able to shoe-horn the sparse memory nodes into the platform-neutral
node_table array.

Thanks,
  Dave



>
> Thanks,
> Badari
>
>   ------------------------------------------------------------------------------------------------------------------------
>                             Name: crash-paca-fix.patch2
>    crash-paca-fix.patch2    Type: Plain Text (text/plain)
>                         Encoding: 7bit
>
>   ------------------------------------------------------------------------------------------------------------------------
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility