[Crash-utility] [patch] remove kernel header include file

Nguyen Anh Quynh aquynh at gmail.com
Wed Mar 22 05:18:10 UTC 2006


hi,

lkcd_dump_v5.h includes <linux/list.h>, which unfortunately includes a
kernel-only header. below is the content of <linux/list.h> on my box
(Ubuntu 5.10): this file has only 1 line

^^^
#include <linux/err_kernel_only.h>
^^^

i guess you guys dont have this compiling problem because you are
running Redhat/FC, not Ubuntu. obviously it is a bad idea to use a
kernel header in userspace. so i propose a patch which puts a new
list.h file in the source tree. please see the patch below (this
"list.h" is taken from Xen source tree, but i guess you have already
seen it in many places)


Signed-off-by: Nguyen Anh Quynh <aquynh at gmail.com>


# diffstat crash.diff
 list.h         |  186 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 lkcd_dump_v5.h |    2
 2 files changed, 187 insertions(+), 1 deletion(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: crash.diff
Type: application/octet-stream
Size: 5804 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20060322/3344e023/attachment.obj>


More information about the Crash-utility mailing list