[Crash-utility] Patch to fix Incorrect Incorrect Processor speed inx86_64

[Dave Anderson]

Sharyathi Nagesh wrote:

> This is a patch to fix incorrect Processor speed being displayed on
> dumps taken over x86_64 machines. Please review and let me know of your
> views...
>
> --- crash-4.0-2.21.old/x86_64.c 2006-02-15 04:10:02.000000000 +0530
> +++ crash-4.0-2.21/x86_64.c     2006-03-23 11:22:43.000000000 +0530
> @@ -1044,13 +1044,13 @@ x86_64_is_task_addr(ulong task)
>  static ulong
>  x86_64_processor_speed(void)
>  {
> -        unsigned long cpu_khz;
> +        unsigned long cpu_khz=0;
>
>          if (machdep->mhz)
>                  return (machdep->mhz);
>
>          if (symbol_exists("cpu_khz")) {
> -                get_symbol_data("cpu_khz", sizeof(long), &cpu_khz);
> +                get_symbol_data("cpu_khz", sizeof(int), &cpu_khz);
>                  if (cpu_khz)
>                          return(machdep->mhz = cpu_khz/1000);
>          }
>
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility

It's in there!  I got your initial non-member posting, and put
it in 4.0-2.22 yesterday.  Here's the changelog from:

 http://people.redhat.com/anderson/crash.changelog.html

 Incorporated initial patch-set to implement support for kernels built
 with CONFIG_SPARSEMEM.  (dwilder at us.ibm.com)

 Fix for post-2.6.15 ppc64 kernels to use cpu_online_map when perusing
 the paca array for the per_cpu_offsets.  (haren at us.ibm.com)

 Fix for ppc64 "bt" command for active tasks that were running in
 user space at the time of crash.  (haren at us.ibm.com)

 Fix to remove dependencies upon any kernel header files so as to
 allow crash to build in a Ubuntu environment.  (aquynh at gmail.com)

 Fix size of x86_64 "cpu_khz" variable to match that of the kernel.
 (sharyath at in.ibm.com)

 Created framework for support of Xen kernel dumpfiles and live Xen
 kernels; this is going to be a long-period work-in-progress affair,
 and the code added in this release is being done now primarily to aid
 in future patch integration efforts.  (anderson at redhat.com)
 (3/23/06)

How's that for service?

Thanks,
  Dave

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20060324/e50b808f/attachment.htm>