[Crash-utility] [PATCH] Fix vmlinux verification for s390(x)

Michael Holzheu holzheu at linux.vnet.ibm.com
Mon Apr 14 16:13:12 UTC 2008


Hi Dave,

Another fix for s390(x) ...

When starting crash with an s390x standalone dump, we get the following message:

WARNING: machine type mismatch:
         crash utility: S390X
         /usr/lib/debug/lib/modules/2.6.18-86.el5/vmlinux: (unknown)

To fix that this patch adds s390(x) support in the is_kernel() function,
where the vmlinux ELF file is verified.

Signed-off-by: Michael Holzheu <holzheu at linux.vnet.ibm.com>
---

 symbols.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

diff -Naurp crash-4.0-6.2/symbols.c crash-4.0-6.2-s390x-warn-fix/symbols.c
--- crash-4.0-6.2/symbols.c	2008-04-14 17:49:21.000000000 +0200
+++ crash-4.0-6.2-s390x-warn-fix/symbols.c	2008-04-14 17:49:27.000000000 +0200
@@ -2540,6 +2540,11 @@ is_kernel(char *file)
 				goto bailout;
 			break;
 
+		case EM_S390:
+			if (machine_type_mismatch(file, "S390", NULL, 0))
+				goto bailout;
+			break;
+
 		default:
 			if (machine_type_mismatch(file, "(unknown)", NULL, 0))
 				goto bailout;
@@ -2573,6 +2578,11 @@ is_kernel(char *file)
 				goto bailout;
 			break;
 
+		case EM_S390:
+			if (machine_type_mismatch(file, "S390X", NULL, 0))
+				goto bailout;
+			break;
+
 		default:
 			if (machine_type_mismatch(file, "(unknown)", NULL, 0))
 				goto bailout;





More information about the Crash-utility mailing list