[Crash-utility] [Patch] Fix backtrace of xen-ia64

Dave Anderson anderson at redhat.com
Wed May 21 12:48:40 UTC 2008


Akio Takebe wrote:
> Hi,
> 
> This patch improves backtrace of xen-ia64.
> If the cpu map is not contiguous, we cannot get the stack address.
> 
> Signed-off-by: Akio Takebe <takebe_akio at jp.fujitsu.com>
> 
> Best Regards,
> 
> Akio Takebe
> ---
> 
> --- crash-4.0-6.3.orig/ia64.c	2008-04-30 02:39:16.000000000 +0900
> +++ crash-4.0-6.3/ia64.c	2008-05-21 15:05:53.000000000 +0900
> @@ -4167,14 +4167,14 @@ ia64_in_mca_stack_hyper(ulong addr, stru
>  	if (!machdep->kvtop(NULL, addr, &paddr, 0))
>  		return 0;
>  
> -	__per_cpu_mca = (ulong *)GETBUF(sizeof(ulong) * xht->pcpus);
> +	__per_cpu_mca = (ulong *)GETBUF(sizeof(ulong) * plen);
>  
>  	if (!readmem(symbol_value("__per_cpu_mca"), KVADDR, __per_cpu_mca,
> -	    sizeof(ulong) * xht->pcpus, "__per_cpu_mca", RETURN_ON_ERROR|QUIET))
> +	    sizeof(ulong) * plen, "__per_cpu_mca", RETURN_ON_ERROR|QUIET))
>  		return 0;
>  
>  	if (CRASHDEBUG(1)) {
> -		for (i = 0; i < xht->pcpus; i++) {
> +		for (i = 0; i < plen; i++) {
>  			fprintf(fp, "__per_cpu_mca[%d]: %lx\n", 
>  		 		i, __per_cpu_mca[i]);
>  		}
> 

ACK -- queued for the next release.

Thanks,
   Dave




More information about the Crash-utility mailing list