[Crash-utility] redundant code

Jun Koi junkoi2004 at gmail.com
Fri Oct 10 01:45:25 UTC 2008


Hi,

Function x86_init_kernel_pgd() in x86.c has a redundant code that
should be removed.

x86_init_kernel_pgd(void)
{
    int i;
    ulong value;

    value = symbol_value("swapper_pg_dir");  // <--- THIS IS NOT NECESSARY

    if (XEN())
        get_symbol_data("swapper_pg_dir", sizeof(ulong), &value);
    else
        value = symbol_value("swapper_pg_dir");

    for (i = 0; i < NR_CPUS; i++)
        vt->kernel_pgd[i] = value;
}


Thanks,
J




More information about the Crash-utility mailing list