[Crash-utility] [PATCH] remove abundant code in memory.c

Dave Anderson anderson at redhat.com
Thu Feb 12 13:38:23 UTC 2009


----- "Jun Koi" <junkoi2004 at gmail.com> wrote:

> Hi,
> 
> This patch removes abundant code in memory.c
> 
> Thanks,
> Jun

Yeah, looks like there was a readmem() call removed.
Queued for the next release.

Thanks,
  Dave
 
> 
> 
> diff a/memory.c b/memory.c
> --- a/memory.c
> +++ b/memory.c
> @@ -3369,7 +3369,6 @@ clear_vma_cache(void)
>  void
>  get_task_mem_usage(ulong task, struct task_mem_usage *tm)
>  {
> -       int rdflags;
>         struct task_context *tc;
> 
>         BZERO(tm, sizeof(struct task_mem_usage));
> @@ -3377,8 +3376,6 @@ get_task_mem_usage(ulong task, struct
> task_mem_usage *tm)
>         if (IS_ZOMBIE(task) || IS_EXITING(task))
>                 return;
> 
> -       rdflags = ACTIVE() ? (QUIET|RETURN_ON_ERROR) :
> RETURN_ON_ERROR;
> -
>         tc = task_to_context(task);
> 
>         if (!tc || !tc->mm_struct)     /* probably a kernel thread */
> 
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility




More information about the Crash-utility mailing list