[Crash-utility] [PATCH] Increase limit for get_syment_array() call to 400
Dave Anderson
anderson at redhat.com
Wed Jan 14 19:02:28 UTC 2009
----- "Bernhard Walle" <bwalle at suse.de> wrote:
> Because s390 kernel System.map contains symbols that repeat very often
>
> grep -c 'L2^B1$' System.map-2.6.27.7-4-default
> 276
>
> this patch increases the limit in the get_syment_array() call from
> 200 to 400. This is a workaround.
>
> Andreas Krebbel already worked to resolve the problem in binutils which prevents
> that symbols from being included in System.map.
> http://sourceware.org/ml/binutils/2009-01/msg00181.html
>
> However, since there are kernels (all 2.6.28 at least) out that contain that
> problem, we should also workaround that in crash in my opinion.
>
>
> Signed-off-by: Bernhard Walle <bwalle at suse.de>
>
>
> 1 file changed, 2 insertions(+), 2 deletions(-)
> symbols.c | 4 ++--
I don't like this patch, mainly because it's a waste of space to even
accept those types of symbols in the first place.
Instead they should be recognized and rejected in the s390_verify_symbol()
and s390x_verify_symbol() functions.
Dave
More information about the Crash-utility
mailing list