[Crash-utility] [PATCH] Add support for 'foreign' page sizes in kdump dumps
Dave Anderson
anderson at redhat.com
Thu Jan 15 16:59:18 UTC 2009
----- "Bernhard Walle" <bwalle at suse.de> wrote:
> * Dave Anderson [2009-01-14 16:17]:
...
>
> > (5) Minor nit -- I'd just as soon leave any changes to ia64_init_hyper() to its
> > maintainer, especially since it makes no sense to make a follow-up call to
> > ia64_check_adjust_pagesize().
>
> Done.
>
>
> Bernhard
I may be preceeding your next response, and I apologize if I am,
but the more I think of it, the more I think that ia64.c should
just be left as is. If the kdump (compressed or not) advertises
a page size that's incompatible with the vmlinux file (via the
empty_zero_page check) then the user must be using the wrong vmlinux
file, and the session attempt should just be aborted as is done now.
I can't think of a reason where resetting the page size to conflict
with the dumpfile could ever possibly work?
Dave
More information about the Crash-utility
mailing list