[Crash-utility] Re: nr_cpus is not calculated properly

[Dave Anderson]

----- "Dave Anderson" <anderson at redhat.com> wrote:

> ----- "Wei Jiang" <talk90091e at gmail.com> wrote:
...
> > So this line
> >    140          nr_cpus = (hdr_size - offset) / sizeof(dump_CPU_info_t);
> >
> > would not get a correct nr_cpus due to the sizeof().
> >
> > A patch to fix this problem as below.
> 
> BTW, what exactly are the ramifications without the patch -- does the
> crash session die during initialization?  How come nobody ran into
> this issue given that the code has been in place for almost 2 years?

Again -- what actually happens as a result of the incorrect nr_cpus calculation?

I need something to put in the crash.changelog.

Dave