[Crash-utility] [PATCH 0/4] To support module percpu symbol

Dave Anderson anderson at redhat.com
Mon Nov 15 13:54:47 UTC 2010


----- "Toshikazu Nakayama" <nakayama.ts at ncos.nec.co.jp> wrote:

> Hello Dave,
> 
> >Hello Toshi,
> >
> >I made several changes to your last patch as we discussed before,
> >and successfully tested it on the x86, x86_64, ia64, s390 and s390x
> >architectures.
> >
> >I've attached the patch as it is queued for the next release.
> >
> >Because I was working against my own updated tree, the patch also 
> >contains a couple other symbol-handling related changes that are
> >also queued for the next release.
> >
> >Thanks for getting the ball rolling for this feature,
> >  Dave
> 
> Because your patch could not apply to crash-5.0.9 with patch command,
> I manually apply them and they can run well over my environs.

Hmmm -- works for me:

  # tar xzf crash-5.0.9.tar.gz
  # cd crash-5.0.9
  # patch -p1 < $HOME/symbols.patch
  patching file help.c
  patching file kernel.c
  patching file alpha.c
  patching file ppc.c
  patching file s390.c
  patching file s390x.c
  patching file ppc64.c
  patching file x86_64.c
  patching file symbols.c
  patching file lkcd_x86_trace.c
  patching file unwind.c
  patching file defs.h
  # 

Maybe you were trying to apply them on top of your last patch?
Anyway, as long as you're happy with the end result...

> I'll use crash-5.0.9 with your patch
> until crash-5.0.10 got available.
> 
> I saw that you've updated whole places where per-cpu or MODULE_SYMBOL
> should be applicable in crash utility.
>

Thanks again Toshi,
  Dave




More information about the Crash-utility mailing list