[Crash-utility] [PATCH v3 0/2] Crash-Utility: crash enhancement to support s390x diskdump

[Mahesh Jagannath Salgaonkar]

On 11/18/2010 07:17 PM, Dave Anderson wrote:
> 
> ----- "Mahesh Jagannath Salgaonkar" <mahesh at linux.vnet.ibm.com> wrote:
> 
>> On 11/17/2010 02:46 PM, Michael Holzheu wrote:
>>> Hello Dave,
>>>
>>> Dave Anderson <anderson at redhat.com> wrote on 11/16/2010 20:30:48:
>>>>> Please review the changes and send in your comments.
>>>>
>>>> Hello Mahesh,
>>>>
>>>> The patch-set looks good so far, except for one minor nit.
>>>>
>>>> Why is "S390" accepted as legitimate here in read_dump_header()?
>>>>
>>>>   @@ -349,6 +352,10 @@ restart:
>>>>                   dd->machine_type = EM_IA_64;
>>>>           else if (machine_type("PPC64"))
>>>>                   dd->machine_type = EM_PPC64;
>>>>   +       else if (machine_type("S390"))
>>>>   +               dd->machine_type = EM_S390;
>>>>   +       else if (machine_type("S390X"))
>>>>   +               dd->machine_type = EM_S390;
>>>>           else {
>>>>                   error(INFO, "%s: unsupported machine type:
>> %s\n",
>>>>                           DISKDUMP_VALID() ? "diskdump" : "compressed kdump",
>>>>
>>>
>>> Correct, machine_type("S390") can be removed, because we currently>
>>> can't have s390 31 bit ELF dumps or kdumps. And probably will never
>>> have.
>>>
>>> Michael
>>>
>> Will remove the machine_type("S390") and roll out new version of the
>> patch.
>>
>> Thanks,
>> -Mahesh.
> 
> Hi Mahesh,
> 
> There's really no need to do that -- I can do it unless there are other
> changes you need to make.  I'm just waiting for somebody to make your two
> dumpfiles available for me to download before I queue it for the next
> release.
> 
> Thanks,
>   Dave

Thanks Dave. I have placed the dumpfiles on a different server and given
read access to Steve Best, he now should be able to get the files
available to you.

Thanks,
-Mahesh.