[Crash-utility] [PATCH v4] Use register value in elf note NT_PRSTATUS to do backtrace

Dave Anderson anderson at redhat.com
Mon May 9 20:35:44 UTC 2011



----- Original Message -----

> I also slightly modified the patches to get_netdump_regs_x86() and
> get_netdump_regs_x86_64() to avoid the goto's, but with no functional
> changes.
> 
> Queued for crash version 5.1.5.
> 
> Thanks,
> Dave

One other thing -- out of sheer paranoia, I've also added this to the
end of read_dump_header():

         dd->flags &= ~(DISKDUMP_LOCAL|KDUMP_CMPRS_LOCAL);
+        pc->flags2 &= ~ELF_NOTES;
         return FALSE;
 }

That will prevent any potential problems with your patch to 
x86_64_get_dumpfile_stack_frame():

         } else if (ELF_NOTES_VALID()) {
                user_regs = bt->machdep;
                ur_rip = ULONG(user_regs +
                        OFFSET(user_regs_struct_rip));
                ur_rsp = ULONG(user_regs +
                        OFFSET(user_regs_struct_rsp));
        }

All of the other places that you use ELF_NOTES_VALID(), you
also check DISKDUMP_DUMPFILE().

Dave




More information about the Crash-utility mailing list