[Crash-utility] [PATCH 05/11] sadump: don't exit if time stamps mismatch

HATAYAMA Daisuke d.hatayama at jp.fujitsu.com
Thu Oct 20 10:42:38 UTC 2011


Two disks on the same diskset configuration can have different time
stamp values. Consider the case where you set up two diskset
configuration so that the first disk covers total physical memory, in
other words, so that the second disk is unused. Then, time stamp on
the second disk is never rewritten and its value results in being
older than that of the first disk.

We should not think of this kind of time stamp mismatch as error. So
don't enter error path if detecting time stamp mismatch.

Signed-off-by: HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com>
---

 sadump.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
-------------- next part --------------
diff --git a/sadump.c b/sadump.c
index 92573bf..d98db41 100644
--- a/sadump.c
+++ b/sadump.c
@@ -290,7 +290,6 @@ restart:
 						      (efi_time_t_to_tm
 						       (&smh->time_stamp))));
 			}
-			goto err;
 		}
 
 		if (smh->sequential_num != 1) {
@@ -550,8 +549,6 @@ add_disk(char *file)
 					      (efi_time_t_to_tm
 					       (&ph->time_stamp))));
 		}
-		free(ph);
-		return FALSE;
 	}
 
 	if (diskid != ph->set_disk_set - 1) {


More information about the Crash-utility mailing list