[Crash-utility] Patch to add comments

Dave Anderson anderson at redhat.com
Tue Apr 10 14:07:16 UTC 2012



----- Original Message -----
> 
> 
> Hello Dave,
> A small cosmetic pach to add comments in the crash flow.
> Of course we may use !# to do this, but to call a shell just for a
> comment seems rather hard ?

True -- but your patch that makes "#" an actual command is way-overkill.

Why not do this:

--- main.c      20 Mar 2012 18:11:46 -0000      1.130
+++ main.c      10 Apr 2012 13:59:45 -0000
@@ -768,6 +768,9 @@ exec_command(void)
         if (is_datatype_command()) 
                 goto reattempt;
 
+       if (STRNEQ(args[0], "#"))
+               return;
+
        if (!(pc->flags & MINIMAL_MODE) &&
            is_gdb_command(TRUE, FAULT_ON_ERROR)) 
                goto reattempt;

Dave
  
 




More information about the Crash-utility mailing list