[Crash-utility] [RFC/PATCH] s390x: Add live dump detection

Michael Holzheu holzheu at linux.vnet.ibm.com
Mon Apr 23 08:54:11 UTC 2012


Hi Dave,


On Fri, 20 Apr 2012 10:03:23 -0400 (EDT)
Dave Anderson <anderson at redhat.com> wrote:
> ----- Original Message -----
> > Hello Dave,
> > 
> > On Thu, 19 Apr 2012 14:44:43 -0400 (EDT)
> > Dave Anderson <anderson at redhat.com> wrote:
> > 
> > [snip]
> > 
> > > I would have no problem with adding a new LIVE_DUMP flag to
> > > pc->flags2, and just checking it in display_sys_stats() and
> > > non_matching_kernel() as you've done below.  In dealing with
> > > dumpfiles generated from snap.so, the "bt" command is pretty
> > > much the only command that probably should be restricted.
> > > However, I don't restrict "bt" with snap.so vmcores because
> > > currently there's no magic/signature/whatever that indicates
> > > what kind of dump it is.  But if you implement a new LIVE_DUMP
> > > flag, I might do it there as well so we've got some consistency.
> > > 
> > > What do you think about that?
> > 
> > Sounds good. So what about introducing a new macro LIVE() that
> > indicates that the dump or live system is inconsistent.
> 
> Good idea -- queued for crash-6.0.6.

Thanks!

Michael




More information about the Crash-utility mailing list