[Crash-utility] [PATCH] s390: Enable live check for --minimal

Dave Anderson anderson at redhat.com
Mon Aug 6 17:13:46 UTC 2012



----- Original Message -----
> Hello Dave,
> 
> Currently on s390 the check for live dumps is called in s390x_init(POST_INIT).
> Unfortunately this code is not executed when the "--minimal" command line
> option is specified. Therefore when using this option, "help -p" does not
> show the correct information for flags2.
> 
> This patch moves the s390x_check_live() invoctation to s390x_init(PRE_GDB),
> that is called also for --minimal.
> 
> Michael

OK, queued for crash-6.0.9.

Dave

> ---
>  s390x.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/s390x.c
> +++ b/s390x.c
> @@ -398,6 +398,7 @@ s390x_init(int when)
>  		machdep->value_to_symbol = generic_machdep_value_to_symbol;
>  		machdep->init_kernel_pgd = NULL;
>  		vt->flags |= COMMON_VADDR;
> +		s390x_check_live();
>  		break;
>  
>  	case POST_GDB:
> @@ -413,7 +414,6 @@ s390x_init(int when)
>  		break;
>  
>  	case POST_INIT:
> -		s390x_check_live();
>  		break;
>  	}
>  }
> 




More information about the Crash-utility mailing list