[Crash-utility] [PATCH] add support to "virsh dump-guest-memory"(qemu memory dump)

[Dave Anderson]

----- Original Message -----
> At 2012-8-21 3:47, Dave Anderson wrote:
> > The patch is looking better, but a few issues still remain to be
> > cleaned up.
> 
> The patches have been modified as you recommended. And the third patch
> also adds some fields to vmcore_data, so "help -n" is modified here
> once again.
> 
> --
> --
> Regards
> Qiao Nuohan

Thanks for the updated patch.  But I am going to defer it until we
first come to an agreement about how to best consolidate the commonality
between the sadump and qemu-mem-dump formats.

I'd like to accept Daisuke's "backup_src_start" bug-fix, but for a new
common init function, it would seem best that these fields should be
the same:
  
  diff --git a/sadump.h b/sadump.h
  index 64c2630..29dce06 100644
  --- a/sadump.h
  +++ b/sadump.h
  @@ -204,7 +204,7 @@ struct sadump_data {
   
   /* Backup Region, First 640K of System RAM. */
   #define KEXEC_BACKUP_SRC_END        0x0009ffff
  -        ulong backup_src_start;
  +        ulonglong backup_src_start;
           ulong backup_src_size;
           ulonglong backup_offset;
   };
  -- 
  
whereas your patch has this:
  
  diff --git a/netdump.h b/netdump.h
  index 2e296ad..4a6d661 100644
  --- a/netdump.h
  +++ b/netdump.h
  @@ -71,6 +71,11 @@ struct vmcore_data {
          struct xen_kdump_data *xen_kdump_data;
          void *vmcoreinfo;
          uint size_vmcoreinfo;
  +/* Backup Region, First 640K of System RAM. */
  +#define KEXEC_BACKUP_SRC_END   0x0009ffff
  +       ulong backup_src_start;
  +       ulong backup_src_size;
  +       ulong backup_offset;
   };
  
Can you change your patch so that they are the same?

And would you like to work on creating the new common 
kdump_backup_region_init() function that can handle both 
vmcore_data and sadump_data structures?

Thanks,
  Dave