[Crash-utility] [PATCH] Rename eppic_typeislocal in the library

Dave Anderson anderson at redhat.com
Fri Dec 7 13:54:34 UTC 2012



Hi Luc,

While you're in the clean-up mode, is there a quick fix
you can make for these bison warnings?:
 
 $ gcc --version
 gcc (GCC) 4.7.2 20120921 (Red Hat 4.7.2-2)
 Copyright (C) 2012 Free Software Foundation, Inc.
 This is free software; see the source for copying conditions.  There is NO
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 
 $ make extensions
 gcc -Wall -nostartfiles -shared -rdynamic -o echo.so echo.c -fPIC -DX86_64  -DGDB_7_3_1
 Cloning into 'eppic'...
 remote: Counting objects: 146, done.
 remote: Finding sources: 100% (146/146), done.
 remote: Total 146 (delta 61)
 Receiving objects: 100% (146/146), 172.98 KiB, done.
 Resolving deltas: 100% (61/61), done.
 cd eppic/libeppic && make
 bison -peppic -v -t -d eppic.y
 eppic.y:178.15: warning: a `;' might be needed at the end of action code
 eppic.y:178.15: warning: future versions of Bison will not add the `;'
 eppic.y:178.41: warning: a `;' might be needed at the end of action code
 eppic.y:178.41: warning: future versions of Bison will not add the `;'
 eppic.y:179.17: warning: a `;' might be needed at the end of action code
 eppic.y:179.17: warning: future versions of Bison will not add the `;'
 eppic.y:179.33: warning: a `;' might be needed at the end of action code
 eppic.y:179.33: warning: future versions of Bison will not add the `;'
 eppic.y: conflicts: 253 shift/reduce, 20 reduce/reduce
 cc -O0 -g -fPIC   -c -o eppic_util.o eppic_util.c
 cc -O0 -g -fPIC   -c -o eppic_node.o eppic_node.c
 cc -O0 -g -fPIC   -c -o eppic_var.o eppic_var.c
 cc -O0 -g -fPIC   -c -o eppic_func.o eppic_func.c
 cc -O0 -g -fPIC   -c -o eppic_str.o eppic_str.c
 cc -O0 -g -fPIC   -c -o eppic_op.o eppic_op.c
 cc -O0 -g -fPIC   -c -o eppic_num.o eppic_num.c
 cc -O0 -g -fPIC   -c -o eppic_stat.o eppic_stat.c
 cc -O0 -g -fPIC   -c -o eppic_builtin.o eppic_builtin.c
 cc -O0 -g -fPIC   -c -o eppic_type.o eppic_type.c
 cc -O0 -g -fPIC   -c -o eppic_case.o eppic_case.c
 cc -O0 -g -fPIC   -c -o eppic_api.o eppic_api.c
 cc -O0 -g -fPIC   -c -o eppic_member.o eppic_member.c
 cc -O0 -g -fPIC   -c -o eppic_alloc.o eppic_alloc.c
 cc -O0 -g -fPIC   -c -o eppic_define.o eppic_define.c
 cc -O0 -g -fPIC   -c -o eppic_input.o eppic_input.c
 cc -O0 -g -fPIC   -c -o eppic_print.o eppic_print.c
 bison -peppicpp -v -t -d eppicpp.y
 eppicpp.y: conflicts: 23 shift/reduce
 cc -O0 -g -fPIC -c eppicpp.tab.c
 cc -O0 -g -fPIC -c eppic.tab.c
 flex -L -Peppic -t eppic.l > lex.eppic.c
 cc -O0 -g -fPIC -c lex.eppic.c
 flex -Peppicpp -t eppicpp.l  > lex.eppicpp.c
 cc -O0 -g -fPIC -c lex.eppicpp.c
 cc -O0 -g -fPIC -o mkbaseop mkbaseop.c
 ./mkbaseop > baseops.c
 cc -O0 -g -fPIC -c baseops.c
 ar ccurl libeppic.a eppic_util.o eppic_node.o eppic_var.o eppic_func.o eppic_str.o eppic_op.o eppic_num.o eppic_stat.o eppic_builtin.o eppic_type.o eppic_case.o eppic_api.o eppic_member.o eppic_alloc.o eppic_define.o eppic_input.o eppic_print.o eppicpp.tab.o eppic.tab.o lex.eppic.o lex.eppicpp.o baseops.o
 gcc -g -I.. -Ieppic/libeppic -I../gdb-7.3.1/bfd -I../gdb-7.3.1/include -I../gdb-7.3.1/gdb -I../gdb-7.3.1/gdb/config -I../gdb-7.3.1/gdb/common -I../gdb-7.3.1 -nostartfiles -shared -rdynamic -o eppic.so eppic/applications/crash/eppic.c -fPIC -DX86_64 -DGDB_7_3_1 -Leppic/libeppic -leppic 
 gcc -Wall -nostartfiles -shared -rdynamic -o trace.so trace.c -fPIC -DX86_64  -DGDB_7_3_1
 gcc -Wall -nostartfiles -shared -rdynamic -o dminfo.so dminfo.c -fPIC -DX86_64  -DGDB_7_3_1
 gcc -Wall -I. -nostartfiles -shared -rdynamic -o snap.so snap.c -fPIC -DX86_64  -DGDB_7_3_1
 $
 
Thanks,
  Dave
 

----- Original Message -----
> Agreed - and done. Thanks
> http://code.google.com/p/eppic/source/detail?r=041dd5a5a165fc29e189debf6ce385d0f4d05e17
> 
> 
> On Fri, Dec 7, 2012 at 7:00 AM, Petr Tesarik <ptesarik at suse.cz>
> wrote:
> 
> > Hi Luc,
> >
> > please consider the attached patch for inclusion in eppic.
> >
> > The actual name should match the name from eppic_api.h.
> > The crash extension worked previously only because the it relied on
> > implicit declaration of the wrong name, which is ugly.
> >
> > Regards,
> > Petr Tesarik
> >
> 
> 
> 
> --
> 
>      - Luc
> 
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility




More information about the Crash-utility mailing list