[Crash-utility] [PATCH v2 3/4] [netdump] Update the flags when ELF Notes are processed

Dave Anderson anderson at redhat.com
Wed Feb 1 14:39:57 UTC 2012



----- Original Message -----
> This patch updates the pc->flags2 with ELF_NOTES flag for netdump, when
> we have NT_PRSTATUS notes available from the core. Currently this flags is set
> only in the case of diskdump. This change would allow us to generalize
> the routines for obtaining stack frame for active tasks, where the GPRS
> are stored in the notes.
> 
> Signed-off-by: Suzuki K. Poulose <suzuki at in.ibm.com>
> ---
> 
>  netdump.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/netdump.c b/netdump.c
> index d23e45c..177bc5c 100644
> --- a/netdump.c
> +++ b/netdump.c
> @@ -1696,6 +1696,9 @@ dump_Elf32_Nhdr(Elf32_Off offset, int store)
>  				}
>  			}
>  		}
> +		/* Set the flags to indicate that we have NT_PRSTATUS notes */
> +		if (nd->num_prstatus_notes > 0)
> +			pc->flags2 |= ELF_NOTES;
>  		break;
>  	case NT_PRPSINFO:
>  		netdump_print("(NT_PRPSINFO)\n");

As we discussed during the first patch-set, I'm not interested in 
changing 32-bit x86 behavior as you've done above.  You said that
you were going to re-spin it with #ifdef PPC.

Dave


 




More information about the Crash-utility mailing list