[Crash-utility] Problem in runq command

[Karlsson, Jan]

Hi Dave

I found a problem with the runq command in the function dump_CFS_runqueues in task.c. The problem is in:

  if (!(rq_sp = per_cpu_symbol_search("per_cpu__runqueues")))
    error(FATAL, "per-cpu runqueues does not exist\n");

as that code does not support single core systems. However the rest of the function seems to handle single core correctly, so by just adding one line:

  if (!(rq_sp = per_cpu_symbol_search("per_cpu__runqueues")))
    if (!(rq_sp = symbol_search("runqueues")))
      error(FATAL, "per-cpu runqueues does not exist\n");

the runq command works as it should. Of course the text in the error message should also be updated to something more proper.

Jan


Jan Karlsson
Senior Software Engineer
MIB

Sony Mobile Communications
Tel: +46703062174
sonymobile.com<http://sonymobile.com/>

[cid:image001.jpg at 01CD6006.CF9C2700]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20120712/b457d018/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.jpg
Type: image/jpeg
Size: 2843 bytes
Desc: image001.jpg
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20120712/b457d018/attachment.jpg>