[Crash-utility] [PATCH] netdump, diskdump: address the issue caused by no NT_PRSTATUS notes

[Hatayama, Daisuke]

> -----Original Message-----
> From: Dave Anderson [mailto:anderson at redhat.com]

> > - The 2nd patch makes crash pass boot-time sanity check to nr_cpus memebr
> of diskdump
> > header on x86 and x86_64 if it is 0. On both architectures, we can get
> cpu
> > information from memory part. In fact, the value of nr_cpus member is
> not used
> > except for the sanity check.
> 
> I'm not sure whether this accomplishes much?  If the vmcore is an x86/x86_64
> compressed kdump, then it will not "goto err", because it would not be
> DISKDUMP_VALID().

Sorry. I noticed I reproduced the behaviour on 6.0.5, fc16 version. I tried reproducing now, and I confirmed 6.0.8 and later versions passed goto err without my patch.

I found the following change on 6.0.8:

         - If a compressed kdump header contains an invalid "nr_cpus" value,
           allow the crash session to continue after printing a warning 
           message.  Without the patch, on non-S390/S390X systems, an invalid
           nr_cpus value generates a message such as "crash: compressed kdump:
           invalid nr_cpus value: 0", and the session subsequently fails with
           the message "crash: vmcore: not a supported file format".  However,
           compressed kdumps have been seen that have an nr_cpus value of 0,
           but the session can still run normally.  The patch changes the 
           message to "WARNING: compressed kdump: invalid nr_cpus value: 0",
           and the session is allowed to continue.
           (anderson at redhat.com)

Thanks.
HATAYAMA, Daisuke