[Crash-utility] [PATCH]: symbol filtering

[Per Fransson]

Hi again,

On Tue, Jan 29, 2013 at 11:34 AM, Per Fransson
<per.fransson.ml at gmail.com> wrote:
> Hi,
>
> For x86, crash avoids storing any '__crc_*' symbols. It should do the
> same for ARM, right? Credit goes to Rabin Vincent for this patch,
> unless you don't like it, in which case you can blame me.
>
> Another thing. The ARM kernel potentially includes a symbol 'PRRR'
> with a value of 0xff0a81a8, defined in arch/arm/mm/proc-v7-2level.S.
> The problem with this is that it's the symbol which ends up
> st->symtable[st->symcnt-1] instead of '_end' which means a lot of
> values will pass this check in in_ksymbol_range():
>
>         if ((value >= st->symtable[0].value) &&
>             (value <= st->symtable[st->symcnt-1].value)) {
>                 if ((st->flags & PERCPU_SYMS) && (value < st->first_ksymbol))
>                         return FALSE;
>                 else
>                         return TRUE;
>         }
>
> How would you prefer dealing with this? How about excluding any
> symbols with values > '_end'? A KSYMS_END flag could be added to the
> machdep->flags. Or just unsetting KSYM_START when '_end' is
> encountered in verify_symbol().
>
> Regards,
> Per

Like this (and you can blame this one on me).

/Per
-------------- next part --------------
A non-text attachment was scrubbed...
Name: no_sym_after_end.patch
Type: text/x-diff
Size: 382 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20130129/7e7e608a/attachment.bin>